search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

Fix #160 - Actually test that ServerDirectoryCleanup removes the files #161

Closed jmarrec closed 18 minutes ago

jmarrec commented 8 months ago

FWIW, the run_dir method is poorly named. It should be "osw_dir" or "workflow_dir". I kinda expected it to be the run/ directory.

DavidGoldwasser commented 23 hours ago

Test has been failing on this. Happens on CI on Jenkins/Linux and locally on Mac.

  1) Error:
ServerDirectoryCleanupTest#test_good_argument_values:
NoMethodError: undefined method `file_types' for ServerDirectoryCleanup:Class
    /Users/dgoldwas/Documents/github/nrel/openstudio-common-measures-gem/lib/measures/ServerDirectoryCleanup/tests/ServerDirectoryCleanup_test.rb:130:in `test_good_argument_values'
DavidGoldwasser commented 18 minutes ago

Thanks @jmarrec !