search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

initial setup to support OpenStudio 3.9.0 #176

Closed DavidGoldwasser closed 4 days ago

DavidGoldwasser commented 1 week ago

test on CI

DavidGoldwasser commented 1 week ago
Screenshot 2024-11-02 at 12 12 10 PM

All errors are in GenericQAQC

Failure Failure: test_uo_blend(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_0422_sm_off_2019(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_uo_mixed(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_0422_sm_off_comstock2013(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_res_a(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_fsr(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_uo_lg_hotel(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_alt_hvac_b(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_alt_hvac_a(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_fail_a(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_0422_sm_off(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
Failure Failure: test_GenericQAQC_pass(Minitest::Result) [/srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/lib/measures/generic_qaqc/tests/measure_Test.rb:146]: Expected false to be truthy.
DavidGoldwasser commented 1 week ago

A little confusing that only 10 fail on rc2 locally on my mac. I have not confirmed for all errors but at least the ones I've dug into have sections in HTML with Can't calculate target EUI. Make sure model has expected climate zone and building type. I assume is missing building type and or climate zone. Still looking into it more. Can't calculate target end use EUIs. Make sure model has expected climate zone and building type.

These are the two mystery tests that fail on CI but not locally on mac test_GenericQAQC_0422_sm_off_2019 test_GenericQAQC_0422_sm_off_comstock2013 Can't find target eirfplr curve for 90.1-2013 WaterCooled Rotary Screw Chiller 0 279tons 0.7kW/ton (at least some tests don't fail this one)

oddly test_GenericQAQC_0422_sm_off which the other tests were based on does fail on both. This last one uses all default arguments which would use 90.1-2013 for template. They have the same weather file and seed model and same arguments except for template.

The two extra ones have messages like this, which I think should not be errors, it is just known limitation of those standards. Not a bad lookup target EUI comparison is not supported yet for ComStock 90.1-2013

DavidGoldwasser commented 1 week ago

14 tests fail both of these.

EUI Reasonableness - Error prevented QAQC check from running (No such file or directory @ rb_sysopen - /srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/mygems/ruby/3.2.0/gems/openstudio-standards-0.7.0.rc1/data/standards/legacy_idf_results.csv).

End Use by Category - Error prevented QAQC check from running (No such file or directory @ rb_sysopen - /srv/jenkins/git/openstudio-common-measures-gem/PR-176/1/mygems/ruby/3.2.0/gems/openstudio-standards-0.7.0.rc1/data/standards/legacy_idf_results.csv).

@mdahlhausen This happens on CI, but not at all to me locally, something platform specific to Linux file paths?