Closed DavidGoldwasser closed 4 years ago
Just a as a heads up 3 measures in model articulation gem also update version modified, so if we find fix here can do there as well. (DOE Prototype, DEER prototype, create baseline)
confirming the blank lines in common-measures and the 3 same measures updating version_modified in model_articulation. The rake openstudio:update_measures calls openstudio measure -t as well, but passes in a bundle and bundle_path:
/Applications/OpenStudio-3.0.0/bin/openstudio --verbose --bundle '/Users/kflemin/repos/openstudio-model-articulation-gem/Gemfile' --bundle_path '/Users/kflemin/repos/openstudio-model-articulation-gem/.bundle/install/' measure -t '/Users/kflemin/repos/openstudio-model-articulation-gem/lib/measures'
good to merge this @DavidGoldwasser
@nllong yes, good to merge.
@nllong and @kflemin There are no functional changes here, just updates to file names to support upload to BCL. I ran measure tests for all measures that changed using OpenStudio CLI before commit and upload to BCL. A few measures still had to be pushed to BCL using web interface instead of rake task.
Here is one more thing we may want to fix before this is merged. I thought you might both have ideas.
When I run the
openstudio measure -t
two measures always update even if I run it multiple times without any changes. Seems the version modified changes which changes the version IDWhen I run
rake openstudio:update_measures
in addition two the two above, 5 additional measures change with new blank line in thereport.html.erb
file. These are all reporting measures. If I run it 6 times it will keep adding an extra line each time.I'm not sure how to prevent either of these, any thoughts? measure.xml files have always been a bit sensitive, but I thought we had addressed most of these.