search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

Fixed with Guidance from Eric Ringold #29

Closed DavidGoldwasser closed 4 years ago

DavidGoldwasser commented 4 years ago

Fixes Issue#28

DavidGoldwasser commented 4 years ago

Realized running CI on this doesn't do anything has this measure's tests are commented out. They are very old and problematic in that they overwrite OpenStudio SQL methods and break CI. https://github.com/NREL/openstudio-common-measures-gem/blob/ventilation_qaqc/lib/measures/VentilationQAQC/tests/VentilationQAQC_Test.rb

New test should be based on template OpenStudio reporting measure template or another reporting measure