search

NREL / openstudio-common-measures-gem

Other
7 stars 15 forks source link

3 1 0 upgrade #39

Closed DavidGoldwasser closed 3 years ago

DavidGoldwasser commented 3 years ago

All tests on dashboard are passing on my local Mac with latest 3.1 alpha installer.

DavidGoldwasser commented 3 years ago

3 of the generic_QAQC tests are failing on CI because of this. They run on my mac. I can test on Window, but @tijcolem is it possible CI is using a different standards gem than is in the last installer?

Error prevented QAQC check from running (undefined methodmodel_get_construction_set' for #)`

Note: the code in this error is new from my last commit. It was added because the model_get_construction_properties method in standards added a new required argument of building_type_category

DavidGoldwasser commented 3 years ago

@nllong should be all ready, I updated to use final extension and standards gem for OpenStudio 3.1.0