search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

Adds description to EV charging measures. #60

Closed tanushree04 closed 3 years ago

tanushree04 commented 3 years ago

Adds descriptions to some of the EV charging measure arguments so that they are autopopulated in the measure.xml file. This would be useful for Ladybug Tools since they autopopulate fields from the measure.xml file.

DavidGoldwasser commented 3 years ago

@tijcolem or @nllong this change was just change to description for arguments. but is getting caught up in CI because of ruby change. Any way to merge this in without tests passing or do you want to get 2.7 working and then merge develop into this?

DavidGoldwasser commented 3 years ago

@tanushree04 if you end up having to make a commit to this branch it is a god idea to run openstudio measure -u on that measure to update the measure.xml and the readme.md file. As that often doesn't happen we should just make a point to do that to all measures before a major release of any measure gem.

DavidGoldwasser commented 3 years ago

I'm replacing this PR with 61 which merges to a 0.3.x-LTS branch and 62 which merges to develop. For PR 62 I've made changes to gem file and upgraded the version tag of common measure to 0.4.0.