search

NREL / openstudio-common-measures-gem

Other
8 stars 15 forks source link

bundle exec rake openstudio:update_measures always adds extra empty line to reporting measure erb files #78

Open DavidGoldwasser opened 3 years ago

DavidGoldwasser commented 3 years ago

@nllong Maybe this should be in extension gem as it isn't unique to this repo. Happens on any reporting measures.

Here is what is odd. The description of the rake task is. Run the CLI task to check for measure updates, but if I use the CLI and use openstudio measure -u lib/measures/reporting_measure or openstudio measure -t lib/measures/ it doesn't do this. Only when I do it through the rake task. Because of this I never update through rake. This isn't new to 3.2

Screen Shot 2021-07-08 at 3 27 39 PM
DavidGoldwasser commented 3 years ago

There is a collection of blank lines that have expanded over time. Doesn't impact how it renders but these unneeded updates create merge conflict headaches. https://github.com/NREL/openstudio-common-measures-gem/blob/develop/lib/measures/openstudio_results/resources/report.html.erb#L37-L44