search

NREL / openstudio-common-measures-gem

Other
7 stars 15 forks source link

Custom emissions reporting measure #80

Closed bonnema closed 3 years ago

nllong commented 3 years ago

sweet, I'll take a look today!

bonnema commented 3 years ago

I say we wait to merge until we get all the data files.

nllong commented 3 years ago

@tijcolem - can you clean up some space of CI por favor?

Caused by: hudson.plugins.git.GitException: Command "git init /srv/jenkins/git/openstudio-common-measures-gem/PR-80/8" returned status code 128:
stdout: 
stderr: error: copy-fd: write returned: No space left on device
fatal: cannot copy '/usr/share/git-core/templates/hooks/applypatch-msg.sample' to '/srv/jenkins/git/openstudio-common-measures-gem/PR-80/8/.git/hooks/applypatch-msg.sample': No space left on device

    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2681)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2611)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2607)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1974)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:1046)
nllong commented 3 years ago

@bonnema - any reason not to merge this down once the tests pass?

bonnema commented 3 years ago

@bonnema - any reason not to merge this down once the tests pass?

I think the only outstanding item is the additional data files, but I think those can be added at a later date.

nllong commented 3 years ago

Ok. I’ll merge once the tests pass! We also need to socialize this more. Maybe we do a quick preso to our group?

bonnema commented 3 years ago

Ok. I’ll merge once the tests pass! We also need to socialize this more. Maybe we do a quick preso to our group?

Sure. Maybe a monthly meeting presentation or something? I know there was a larger group of folks interested in this (that might not necessarily be in our group) so there might be a better forum. I am good with whatever.

tijcolem commented 3 years ago

@nllong Disk space filled up as I recently scheduled more jobs on these CI runners. I re-run this job now and should run fine as plenty of disk space.

nllong commented 3 years ago

@nllong Disk space filled up as I recently scheduled more jobs on these CI runners. I re-run this job now and should run fine as plenty of disk space.

sweet, thanks @tijcolem

nllong commented 3 years ago

Thanks @bonnema and @tijcolem ... merging now that tests are passing.