search

NREL / openstudio-ee-gem

Other
1 stars 0 forks source link

feat: Adds measures from BRICR and removes duplicates from OS-Common-Measures #11

Closed corymosiman12 closed 3 years ago

DavidGoldwasser commented 3 years ago

@corymosiman12 there are now 5 load errors in CI for this. Those will have to be addressed before this can be merged.

DavidGoldwasser commented 3 years ago

Note that https://github.com/NREL/openstudio-ee-gem/pull/12 should get merged to develop before this one is. The one there is setup with latest extension and standards gem and all test passed. Maybe you should merge that branch into this, or wait for @nllong to merge that and just update this branch from develop.

nllong commented 3 years ago

@corymosiman12 -- I think develop is ready to be merged up. I am slightly concerned that this is now aligned with the upcoming OS 3.1 release. Do we foresee any compatibility issues between OS 3.0.x and 3.1? @DavidGoldwasser

corymosiman12 commented 3 years ago

@nllong removing this PR in favor of a patch to 0.2.0 see #13