search

NREL / openstudio-ee-gem

Other
1 stars 0 forks source link

040 upgrade #27

Closed DavidGoldwasser closed 3 years ago

DavidGoldwasser commented 3 years ago

Upgrade to 0.4.0 ext gem and Ruby 2.7

DavidGoldwasser commented 3 years ago

@mdahlhausen the one failing measure here looks similar to RadiantDoas in common measures. Just 1 out of 12 tests failing for this measure.

Failure: test_office_radiant_doas(Minitest::Result) [/srv/jenkins/git/openstudio-ee-gem/PR-27/1/.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.12/lib/openstudio-standards/prototypes/common/objects/Prototype.radiant_system_controls.rb:28]: NoMethodError: undefined methodto_CoilCoolingLowTempRadiantVarFlow' for # /srv/jenkins/git/openstudio-ee-gem/PR-27/1/.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.12/lib/openstudio-standards/prototypes/common/objects/Prototype.radiant_system_controls.rb:28:in model_add_radiant_proportional_controls' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.12/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb:4719:inblock in model_add_low_temp_radiant' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.12/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb:4638:in each' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.12/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb:4638:inmodel_add_low_temp_radiant' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/.bundle/install/ruby/2.7.0/gems/openstudio-standards-0.2.12/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb:5985:in model_add_hvac_system' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/lib/measures/nze_hvac/measure.rb:162:inadd_system_to_zones' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/lib/measures/nze_hvac/measure.rb:411:in run' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/lib/measures/nze_hvac/tests/NZEHVAC_Test.rb:139:inrun_nze_hvac_measure_test' /srv/jenkins/git/openstudio-ee-gem/PR-27/1/lib/measures/nze_hvac/tests/NZEHVAC_Test.rb:269:in test_office_radiant_doas'

mdahlhausen commented 3 years ago

yes, same issue, and same fix in the next version of standards