search

NREL / openstudio-ee-gem

Other
1 stars 0 forks source link

pre-release updates #38

Closed DavidGoldwasser closed 2 years ago

DavidGoldwasser commented 2 years ago

since no measures changed not running rubocop, update_copyright, or update_measures on this, will introduce changes to more than 50 files.

DavidGoldwasser commented 2 years ago 
Failure: test_office_radiant_doas(Minitest::Result) [/srv/jenkins/git/openstudio-ee-gem/PR-38/1/lib/measures/nze_hvac/tests/NZEHVAC_Test.rb:223]: For test_office_radiant_doas there were 77.5 unmet occupied heating hours and 580.7 unmet occupied cooling hours (total: 658.2), more than the limit of 650.0.

Hmm, we had loosened this up. Either it changed a bit more or that commit was lost, Wha is odd, is this PR doesn't have any measure changes, just updating gemspec for standard to 0.2.16 instead of 0.2.15 (but it should be used). Probably mre about CI version of OS changing.

cc: @mdahlhausen @tijcolem

DavidGoldwasser commented 2 years ago

Ok, I don't see that change to the test, so I'll re-commit it to this in a minute. Will take a few hours to test.

DavidGoldwasser commented 2 years ago

That ran quicker than I thought. @mdahlhausen if you want to review instead of Nick before the merge that is fine.