custom_height_bar not applying for PrimarySchool

[DavidGoldwasser]

when custom_height_bar arg is true it for PrimarySchool, ScecondarySchool, and Warehouse it should pull tall spaces out into it's own bar. This still works for SecondarySchool but doesn't for PrimarySchool. I think we may have had building type or space type name adjustment that might have caused this. In the the past this worked for PrimarySchool.

[DavidGoldwasser]

@tijcolem and @kflemin as a heads up I think we will need an updated Extension gem for fix this for 3.6.0.

CC @mdahlhausen

[DavidGoldwasser]

Unit test doesn't fail now. Maybe best way to test this is to loop through spaces and finding one of the tall ones and loop through vertices finding min and max z to check height?

[DavidGoldwasser]

Hmm, looking back I don't think we ever treated PrimarySchool with custom height support. Only SecondarySchool and Warehouse.

So given that we don't have to fit this into the release, but still should re-evaulate if this should be supported for Primary. For secondary the custom height for Auditorium and Gym are 26 feet. Library and Cafeteria are not custom heights.

[DavidGoldwasser]

Ok, so no rush to change for 3.6.0. I added enhancement tag to this. In addition to adding PrimarySchool, there may be more spaces to include on Secondary school. And we could also pull in other building types.

There is also a variation of this typical for a hotel or other commercial buildings. Often the first X (1-2) stories have higher ceilings. Unlike the current setup for pulling spaces like gyms to their own bar, this hotel style approach would use the same bar but would just have bottom x above grade stories taller, and would put the expected space types there. We already reverse sort space types by ratio and put smaller ones at bottom, which may turn out to be correct in many cases.