NREL / openstudio-load-flexibility-measures-gem

Other
1 stars 2 forks source link

Update to new openstudio-standards methods #69

Closed mdahlhausen closed 5 days ago

mdahlhausen commented 1 month ago

As described in https://github.com/NREL/openstudio-standards/pull/1820, these two lines will need to change to be able to use the next version of openstudio-standards (version 0.7.0).

openstudio-load-flexibility-measures-gem\lib\measures\add_hpwh\measure.rb#L517 std.model_add_heatpump_water_heater -> OpenstudioStandards::ServiceWaterHeating.create_heatpump_water_heater

openstudio-load-flexibility-measures-gem\lib\measures\add_hpwh\measure.rb#L533 std.model_add_water_heater -> OpenstudioStandards::ServiceWaterHeating.create_water_heater

DavidGoldwasser commented 1 week ago

@mdahlhausen This is what I see after this updates

1) Error: AddHpwhTest#test_custom_args_WrappedCondenser_specific_zone: ArgumentError: unknown keywords: :type, :parasitic_fuel_consumption_rate, :swh_temp_sch, :cop, :shr, :tank_ua :/ruby/3.2.0/gems/openstudio-standards-0.7.0.rc1/lib/openstudio-standards/service_water_heating/create_water_heater.rb:198:in create_heatpump_water_heater' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:517:inblock in run' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:483:in each' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:483:inrun' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/tests/add_hpwh_test.rb:192:in `test_custom_args_WrappedCondenser_specific_zone'

2) Error: AddHpwhTest#test_good_argument_values: ArgumentError: wrong number of arguments (given 12, expected 1) :/ruby/3.2.0/gems/openstudio-standards-0.7.0.rc1/lib/openstudio-standards/service_water_heating/create_water_heater.rb:28:in create_water_heater' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:533:inblock in run' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:483:in each' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:483:inrun' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/tests/add_hpwh_test.rb:53:in `test_good_argument_values'

3) Error: AddHpwhTest#test_custom_args_PumpedCondenser_specific_zone: ArgumentError: unknown keywords: :type, :parasitic_fuel_consumption_rate, :swh_temp_sch, :cop, :shr, :tank_ua :/ruby/3.2.0/gems/openstudio-standards-0.7.0.rc1/lib/openstudio-standards/service_water_heating/create_water_heater.rb:198:in create_heatpump_water_heater' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:517:inblock in run' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:483:in each' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/measure.rb:483:inrun' /Users/dgoldwas/Documents/github/nrel/openstudio-load-flexibility-measures-gem/lib/measures/add_hpwh/tests/add_hpwh_test.rb:142:in `test_custom_args_PumpedCondenser_specific_zone'

mdahlhausen commented 1 week ago

The methods use keyword arguments, not positional arguments. See the method (https://github.com/NREL/openstudio-standards/blob/master/lib/openstudio-standards/service_water_heating/create_water_heater.rb) You need to pass in keyword arguments. Also, the methods blocks aren't formatted - need to align the arguments line by line (see rubocop).