search

NREL / openstudio-model-articulation-gem

Other
7 stars 9 forks source link

create_typical_building_from_model inconsistencies in hvac_chs selections and add_cbecs_hvac_system options #100

Open eringold opened 2 years ago

eringold commented 2 years ago

The following hvac_chs arguments in create_typical_building_from_model do not exactly match cases in add_cbecs_hvac_system in Model.hvac.rb and will cause the measure to fail with 

HVAC system type #{args['system_type']} not recognized. Check input system type argument against Model.hvac.rb for valid hvac system type names.
Bad arguments are: Argument Value Reason
'Ideal Air loads' Does not exist in Model.hvac.rb
'DOAS with fan coil district chilled water with no heat' Trailing space: https://github.com/NREL/openstudio-model-articulation-gem/blob/76ab1d7de00f4326250b69e0cd2679ef875e096b/lib/measures/create_typical_building_from_model/resources/Model.hvac.rb#L202
'Fan coil district chilled water with no heat' Trailing space: https://github.com/NREL/openstudio-model-articulation-gem/blob/76ab1d7de00f4326250b69e0cd2679ef875e096b/lib/measures/create_typical_building_from_model/resources/Model.hvac.rb#L301
'PSZ-AC district chilled water with baseboard district hot water' Does not exist in Model.hvac.rb
'VAV air-cooled chiller with central air source heat pump reheat' Trailing space: https://github.com/NREL/openstudio-model-articulation-gem/blob/76ab1d7de00f4326250b69e0cd2679ef875e096b/lib/measures/create_typical_building_from_model/resources/Model.hvac.rb#L529

@DavidGoldwasser I could fix the trailing spaces but not sure how you'd want to address the missing types.