0.10.0 rc2 testing with 3.8.0rc2

[DavidGoldwasser]

Current Failing Tests

• [ ] BlendedSpaceTypeFromModel: 2 tests fail (may need to update log to catch warnings)
• [ ] CreateDOEPrototypeBuilding: 2 tests fail NameError: uninitialized constant BTAP::Environment eval:416:in (talk to Matt)
• [ ] CreateDEERPrototypeBuilding 1 test error (Standards.Model.rb:3071]: TypeError: Expected argument 1 of type std::vector< openstudio::model::Material >::value_type const &, but got OpenStudio::Model::OptionalMaterial #<OpenStudio::Model::OptionalM)
• [ ] DEERSpaceTypeAndConstructionSetWizard: 1 test error same as above (Standards.Model.rb:3071]: TypeError: Expected argument 1 of type std::vector< openstudio::model::Material >::value_type const &, but got OpenStudio::Model::OptionalMaterial #<OpenStudio::Model::OptionalM)
• [ ] CreateBarFromBuildingTypeRatios:
  • [x] 1 expected to fail passes, need to update code to look for sum of fraction > 1.0
  • [ ] 1 fail with ERROR MESSAGES[openstudio.model.Surface] Initial area of other surface 'Surface 411' 41.0139 does not equal post intersection area 26.3122. (Not sure what changed with 3.8, maybe because Ruby upgrade)
  • [ ] 2 fail with exterior wall check fail ERROR MESSAGES [openstudio.standards.Geometry.Create] North/South walls don't have the expected area (actual 2,849.4897 ft^2, target 2,449.4897 ft^2) [openstudio.standards.Geometry.Create] East/West walls don't have the expected area (actual 2,032.9932 ft^2, target 1,632.9932 ft^2)
  • [ ]
• [ ] CreateBarFromDOEBuildingTypeRatios: 4 tests failed (4 are related to warning count, 4 are for unknown reasons. Tests may be similar to above)
• [ ] CreateBarFromDEERBuildingTypeRatios: only test fails, I still need to update this measure for 3.8.0
• [x] CreateBarFromModel: all 9 tests errors, I still need to update this measure for 3.8.0 (tested with 0.6.1 standards in system ruby)
• [ ] CreateBarFromSpaceTypeRatios: all 3 tests errors, I still need to update this measure for 3.8.0
• [ ] CreateTypicalBuildingFromModel: all 60 tests error (TypeError: Expected argument 1 of type std::vector< openstudio::model::Material >::value_type const &, but got OpenStudio::Model::OptionalMaterial #<OpenStudio::Model::OptionalM) This might just be DEER. Here are other ones
  • [ ] Failure: test_small_office_no_extra_loads_with_pvav(Minitest::Result) [/srv/jenkins/git/openstudio-model-articulation-gem/PR-138/33/mygems/ruby/3.2.0/gems/openstudio-standards-0.6.0/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb:7399]: NoMethodError: undefined method include?' for nil:NilClass /srv/jenkins/git/openstudio-model-articulation-gem/PR-138/33/mygems/ruby/3.2.0/gems/openstudio-standards-0.6.0/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb:7399:inmodel_add_hvac_system'. This is 7399. Not sure why system_type would be nil.if system_type.include? 'with DOAS with DCV'
  • [ ] Failure: test_small_office(Minitest::Result) [/srv/jenkins/git/openstudio-model-articulation-gem/PR-138/33/mygems/ruby/3.2.0/gems/openstudio-standards-0.6.0/lib/openstudio-standards/standards/standard.rb:36]: RuntimeError: ERROR: Did not find a class called '{"add_constructions"=>true, "add_elevators"=>true, "add_exhaust"=>true, "add_exterior_lights"=>true, "add_hvac"=>true, "add_internal_mass"=>true, "add_refrigeration"=>true, "add_space_type_loads"=>true, "add_swh"=>true, "add_thermostat"=>true, "clg_src"=>"Electricity", "enable_dst"=>true, "exterior_lighting_zone"=> (This is on DOE version)
  • [ ] One Error: ERROR MESSAGES [openstudio.standards.Model] Could not find construction properties for: 90.1-2010-ClimateZone 2A-ExteriorWall--Nonresidential.
• [ ] CreateTypicalDEERBuildingFromModel: only test errors I still need to update is measure for 3.8.0

• [ ] CreateTypicalDOEBuildingFromModel: all 7 tests errors (different climate zones and vintages) ERROR MESSAGES [openstudio.standards.Model] Could not find construction properties for: 90.1-2004-ClimateZone 5B-ExteriorWall--Nonresidential.

Pre release

• [ ] Try and fix open issues
• [ ] Make sure xml files updated to 3.8.0 where needed
• [ ] Update readme and change log

[DavidGoldwasser]

I just fixed (or in one case skipped) failing tests for this repo, so it is ready for release and going to BCL.