Closed DavidGoldwasser closed 4 years ago
This branch was made from the rake_update branch which is open as another pull request.
@DavidGoldwasser -- looks like the tests are failing. Is this still good to merge?
@nllong One in 15 tests in SetWindowToWallRatioByFacade failed, I'm almost certain because of intersection, as it is test with door, that probably splits walls before adding windows. This measure wasn't touched here. Do I just keep kicking off CI again until it passes? I feel like I'm spinning plates trying to keep them from falling in never ending loop.
Failure: test_door_nothing(Minitest::Result) [/home/ubuntu/jenkins/workspace/dio-model-articulation-gem_PR-29/openstudio_3_x/lib/measures/SetWindowToWallRatioByFacade/tests/SetWindowToWallRatioByFacade_Test.rb:601]: Expected false to be truthy.
Oh man. Non determistic CI is a major problem. Why would kicking off another CI run cause things to pass all of a sudden? Which part of the model generation is non-deterministic?
@nllong Non-Deterministic items
@nllong Looks like the second attempt worked :) I know we still have to address this, I'll try to file an OS issue this weekend if I can setup script to show it.
@nllong and @kflemin
I renamed any files under tests directory that start with test and updated XML's and other references to those files before trying to stage and push to BCL. Everything that was put in the
staged/update
directory was uploaded using rake push, but everything instaged/push
failed to post with rake task. All but one of them successfully uploaded using web interface with one exception.create_parametric_schedules
shows waiting for approval, but I don't see in it group content.One last thing. For some reason
create_DOE_prototype_building
shows up inpush
instead ofupdate
even though it is already on BCL with matching UUID. After manually updating the measure instead, and re-staging, it still showed as 'push`. Not sure of the cause