search

NREL / openstudio-model-articulation-gem

Other
7 stars 9 forks source link

merge_floorspace_js_with_model strips climate zone assignment and maybe weather file #57

Open DavidGoldwasser opened 3 years ago

DavidGoldwasser commented 3 years ago

Something, not yet identified, changed in recent OS that striped out the climate zone assignment when merging FloorSpaceJS with model. I could harvest early in the measure and re-assign later, but would rather identify and have core issue fixed in OpenStudio. My quick solution was to run this before instead of after ChangeBuildingLocation in workflows. That seemed to work fine for now.

I believe the issue is here https://github.com/NREL/openstudio-model-articulation-gem/blob/develop/lib/measures/merge_floorspace_js_with_model/measure.rb#L121-L122

mm = OpenStudio::Model::ModelMerger.new mm.mergeModels(model, new_model, rt.handleMapping)

If I an confirm that update OS issue here https://github.com/NREL/OpenStudio/issues/4166

DavidGoldwasser commented 3 years ago

@tanushree04 if you have any new details about this please add them.

DavidGoldwasser commented 3 years ago

Based on feedback from UO testing, it does appear this appeared in 3.1.0 and not in 3.0.1

jmarrec commented 3 years ago

Cf https://github.com/NREL/OpenStudio/pull/4245 that should fix it.

To have your measure work including in 3.1.0, I would modify the existing measure to manually add the mappings to site (cf https://github.com/openstudiocoalition/OpenStudioApplication/pull/221/files#diff-2308b84bfa5f511be6f8503830731cfb94e18211fb1596b44b6e3840866b3963R523) , or make use of suggestHandleMapping

ref discussion here: https://github.com/NREL/OpenStudio/issues/4166#issuecomment-779758805

    mm = OpenStudio::Model::ModelMerger.new
    handleMap = mm.suggestHandleMapping(model, new_model)
    mm.mergeModels(model, new_model, handleMap)
DavidGoldwasser commented 3 years ago

Thanks @jmarrec I missed this, I'll take a look at it soon.