Update merge_floorspace_js_with_model to assign OS standards building type and space type

NREL / openstudio-model-articulation-gem

Other

7 stars 9 forks source link

Update merge_floorspace_js_with_model to assign OS standards building type and space type #82

Open DavidGoldwasser opened 3 years ago

DavidGoldwasser commented 3 years ago

See this PR that adds it. Use development GUI to make JSON file. Add to test for this measure and add code to measure to make use of it. Leave old method with name lookup as backup for older JSON files. https://github.com/NREL/floorspace.js/pull/397

DavidGoldwasser commented 3 years ago

Actually ideal place to fix it be should be in core OS https://github.com/NREL/OpenStudio/blob/e603410ac3567d44e7660294f3b06a8a2d591118/src/model/ThreeJSReverseTranslator.cpp#L240