search

NREL / openstudio-model-articulation-gem

Other
7 stars 9 forks source link

create_typical_building_from_model adds OS:Site:GroundTemperature:FCfactorMethod but does not use C-Factor or F-Factor constructions #91

Open craigers290 opened 2 years ago

craigers290 commented 2 years ago

Based on gem v0.5.0 and OS v3.3.0

Expected behavior is to either use OS:Site:GroundTemperature:BuildingSurface with the Outside Boundary Condition of 'Ground'

OR use the OS:Site:GroundTemperature:FCfactorMethod with appropriate F-factor or C-factor constructions and Outside Boundary Condition of 'GroundFCfactorMethod'

craigers290 commented 2 years ago

@DavidGoldwasser, this one is messing with our calculators pretty seriously since VT tends to have small buildings (lots of relative ground contact) and very cold weather file assumptions that end up being used for the "Ground" condition. Generally I agree in principal with moving towards FCfactors, but without the appropriate constructions mapped to the vintages this half implementation is much worse than the old way of assigning "appropriate" OS:Site:GroundTemperature:BuildingSurface objects per the PNNL prototypes.

craigers290 commented 2 years ago

Maybe you could just add both objects?

DavidGoldwasser commented 2 years ago

Sorry this flew below the radar, I'll start looking into it. Maybe a separate question from this is using E+ Kiva objects for ground modeling

craigers290 commented 1 year ago

Sorry this flew below the radar, I'll start looking into it. Maybe a separate question from this is using E+ Kiva objects for ground modeling

@DavidGoldwasser, ultimately that has been our solution to avoid future issues like this if the methodology changes again. We now insert a measure to add Kiva objects downstream of this.