add warnings to SetWindowToWallRatio to categorize cases when WWR can't be applied

NREL / openstudio-model-articulation-gem

Other

7 stars 9 forks source link

add warnings to SetWindowToWallRatio to categorize cases when WWR can't be applied #95

Closed MatthewSteen closed 2 years ago

MatthewSteen commented 2 years ago

Add to #94. This measure could use a refactor in my opinion, so I've tried to work with the existing architecture for now. I added a module for functions used by the measure, which I think is a better design paradigm than a very long run method. See the Create Baseline Building measure's run method, which mostly just makes calls to other modules.

MatthewSteen commented 2 years ago

@DavidGoldwasser this is ready for a review. I did not add tests for the two new functions because the measure needs a lot of rework in my opinion.

MatthewSteen commented 2 years ago

Note I added a hack in 20d732a related to https://github.com/NREL/OpenStudio/issues/4601. Should revisit to ensure actual WWR is as close to requested as possible.