NREL / openstudio-model-articulation-gem

Other
7 stars 9 forks source link

cleanup resulting standards space types for blend space types from model #99

Open DavidGoldwasser opened 2 years ago

DavidGoldwasser commented 2 years ago

It looks like it may grab the standards building type and standards space type from either the first space type. This should either be stripped out or should be changed to whatever building type or space type represents the largest portion fo the space type. I think its cleaner to strip it out to avoid confusion. The screenshot below shows current state. This happens downstream and doesn't generally impact other measures that change the model (but someone could try to use it that way). It was creating confusing results for generic_qaqc measure that was providing comparison values for those space types.

I may use building and space type each named Blended. If there is an easy way to check if all space types had the same building type, but I think the building type tag an be primary fallback here.

Screen Shot 2022-04-19 at 3 39 07 PM