search

NREL / openstudio-standards

Other
78 stars 57 forks source link

prm sizing run test causes git issues #1386

Closed mdahlhausen closed 2 days ago

mdahlhausen commented 1 year ago

See this method def plant_loop_total_cooling_capacity(plant_loop, sizing_run_dir = Dir.pwd) The Dir.pwd causes the sizing run directory to be located wherever it is called from and can cause issues with commits.

weilixu commented 1 year ago

Hi @mdahlhausen, a quick question - are you running the test on Linus/WSL or Windows? Could you provide the file and script that runs into this problem? I can duplicate the issue and possibly fix it today.

mdahlhausen commented 1 year ago

@weilixu I ran into this on my windows machine. It's happening with several tests in test_appendix_g_prm.rb that generate a chilled water loop. Seems like #1385 may be failing some regression tests because of this issue.

weilixu commented 1 year ago

Some of the test case's directory path length in the PRM test suit are longer than 260 char, which often result in error when trying to open those directories on Window (In window, max length of path directory is 260 characters). I wonder if it is because of this?

There is a global variable at the top of test_appendix_g_prm.rb: MAX_PATH_CHAR. Could you se this variable to 200 and then run those failed test cases again and see if the errors are resolved?

mdahlhausen commented 1 year ago

@weilixu just finished running the tests with and without the max path set. Still having the same errors finding and loading the results.

mdahlhausen commented 1 year ago

Update: this is a max path issue on windows. PNNL to fix by shortening test names.

mdahlhausen commented 2 days ago

Fixed with this commit.