search

NREL / openstudio-standards

Other
78 stars 56 forks source link

Select climate zone from list - Wrong selection #1711

Open mioruggieroguida opened 3 months ago

mioruggieroguida commented 3 months ago

Should this be .min?

https://github.com/NREL/openstudio-standards/blob/f1c7d8772e246af70ac57350ccdf9da4c813295d/lib/openstudio-standards/standards/Standards.Model.rb#L5154

mdahlhausen commented 3 months ago

Consider defaulting climate zone to minimal value. Steps to reproduce:

require 'openstudio'
require 'openstudio-standards'
model = OpenStudio::Model::Model.new

std = Standard.build('DOE Ref 1980-2004')
puts std.model_find_climate_zone_set(model, 'ASHRAE 169-2013-1B')
puts std.model_find_climate_zone_set(model, 'ASHRAE 169-2013-4A')
puts std.model_find_climate_zone_set(model, 'ASHRAE 169-2013-7B')

std = Standard.build('90.1-2013')
puts std.model_find_climate_zone_set(model, 'ASHRAE 169-2013-1B')
puts std.model_find_climate_zone_set(model, 'ASHRAE 169-2013-4A')
puts std.model_find_climate_zone_set(model, 'ASHRAE 169-2013-7B')