NREL / openstudio-standards

Other
78 stars 56 forks source link

Refactor Space, ThermalZone, and Constructions modules #1727

Closed mdahlhausen closed 3 months ago

mdahlhausen commented 3 months ago

Pull request overview

This PR moves methods of Standards.Space, Standards.ThermalZone, and Standards.Construction and puts them into new Space, ThermalZone, and Constructions modules. It also moves several NRCAN envelope methods into the Constructions module.

Pull Request Author

Review Checklist

This will not be exhaustively relevant to every PR.

mdahlhausen commented 3 months ago

@ckirney, @phylroy, and @eringold optional review appreciated

This removes or moves a lot of NRCAN envelope methods and methods from Standards.Construction into a the Constructions module. It also moves several Space and ThermalZone methods. All adjustments to NRCAN code are made; it shouldn't break anything in openstudio-standards itself.