Fix deer lookup for simple glazing - Githubissues

NREL / openstudio-standards

Other

80 stars 58 forks source link

Fix deer lookup for simple glazing #1743

Closed mdahlhausen closed 4 months ago

mdahlhausen commented 4 months ago

add a valid lookup for deer simple glazing constructions include properties in name for name parsing

Pull request overview

Fixes an issue with DEER templates in create typical

Pull Request Author

[x] Data changes or additions
[x] Added tests for added methods
[x] Resolved yard documentation errors for new code (ran bundle exec rake doc)
[x] Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
[x] All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

[x] Perform a code review on GitHub
[x] All related changes have been implemented: method additions, changes, tests
[x] Check rubocop errors
[x] Check yard doc errors
[x] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[x] CI status: all green or justified