The radiant slab construction was only checking for 'Ground' and 'Outdoors' conditions, and treating everything else and interior. Then it would try to find an adjacent surface. That did not exist for models with the 'GroundFCfactorMethod' boundary condition. Adjust to allow multiple radiant slab ground boundary conditions, and check if an adjacent surface exists before getting it.
Pull request overview
Pull Request Author
[x] Method changes or additions
[x] Resolved yard documentation errors for new code (ran bundle exec rake doc)
[x] Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
[x] All new and existing tests passes
Review Checklist
This will not be exhaustively relevant to every PR.
[x] Perform a code review on GitHub
[x] All related changes have been implemented: method additions, changes, tests
[x] Check rubocop errors
[x] Check yard doc errors
[x] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
The radiant slab construction was only checking for 'Ground' and 'Outdoors' conditions, and treating everything else and interior. Then it would try to find an adjacent surface. That did not exist for models with the 'GroundFCfactorMethod' boundary condition. Adjust to allow multiple radiant slab ground boundary conditions, and check if an adjacent surface exists before getting it.
Pull request overview
Pull Request Author
bundle exec rake doc)bundle exec rake rubocop)Review Checklist
This will not be exhaustively relevant to every PR.