NREL / openstudio-standards

Other
78 stars 56 forks source link

Logic error in zone_hvac_component_apply_standard_controls #1753

Open jmarrec opened 1 month ago

jmarrec commented 1 month ago

https://github.com/NREL/openstudio-standards/blob/5fe0b590b03ceebe71996e66501922280f0d1515/lib/openstudio-standards/standards/Standards.ZoneHVACComponent.rb#L240-L243

Should be return true if, not unless. Otherwise you end up calling get() on an unitialized optional.