Update the base ASHRAE and DEER schedule .jsons to include or ComStock schedules or be replaced by typical values from ComStock. Then remove schedules from ComStock ASHRAE and DEER worksheets and delete all the identical copies of the schedules.json files across all ComStock vintages. This reduces the installed gem size from 519 MB to 306 MB.
The only change that may impact ComStock results are keeping the ASHRAE version of the refrigerated case restocking schedule in some buildings.
Pull Request Author
[x] Data changes or additions
[x] Added tests for added methods
[x] All new and existing tests passes
Review Checklist
This will not be exhaustively relevant to every PR.
[x] Perform a code review on GitHub
[ ] All related changes have been implemented: method additions, changes, tests
[x] Check rubocop errors
[x] Check yard doc errors
[ ] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[ ] If a new feature, test the new feature and try creative ways to break it
Pull request overview
Update the base ASHRAE and DEER schedule .jsons to include or ComStock schedules or be replaced by typical values from ComStock. Then remove schedules from ComStock ASHRAE and DEER worksheets and delete all the identical copies of the schedules.json files across all ComStock vintages. This reduces the installed gem size from 519 MB to 306 MB.
The only change that may impact ComStock results are keeping the ASHRAE version of the refrigerated case restocking schedule in some buildings.
Pull Request Author
Review Checklist
This will not be exhaustively relevant to every PR.