search

NREL / openstudio-standards

Other
83 stars 58 forks source link

Test Conditioned and Unconditioned Spaces #183

Closed phylroy closed 7 years ago

phylroy commented 7 years ago

I've noticed some conditioned and unconditioned warnings in some of the output in the past. Do a scan to determine if all the models spaces: 1) Have a spacetype 2) Are part of a zone 3) If the spacetype == undefined then the associated thermalzone should not be conditioned, else the thermalzone should be conditioned.

Write a test around this in the QAQC of BTAPResults.

padmassun commented 7 years ago

please see https://github.com/padmassun/OpenStudio-measures/commit/0bf82fa81e8daff9855cc026078d6e5634070134

phylroy commented 7 years ago

Looks good, however this is more for a sanity check than an NECB rule.

Also this line will cause problems...you should use the spacetype name..not the space name https://github.com/padmassun/OpenStudio-measures/commit/0bf82fa81e8daff9855cc026078d6e5634070134#diff-994a5a82af22e596141587e7438738ceR1396

padmassun commented 7 years ago

see https://github.com/NREL/OpenStudio-measures/commit/437444d50992e584b6f39d1f346b3251e24a97d5