Space type name does not match with space type on excel sheet for SmallHotel

[padmassun]

/home/nrcan/windows-host/projects/OpenStudio-measures/NRCAN_working_measures/BTAPResults/resources/necb_2011_spacetype_info.csv
Zero matches found for [{2=>"Storage area - occsens", 1=>"Space Function"}]
space type of [Storage area - occsens] and/or building type of [Space Function] was not found in the excel sheet for space: [FrontStorageFlr1]
Zero matches found for [{2=>"Storage area - occsens 3", 1=>"Space Function"}]
space type of [Storage area - occsens 3] and/or building type of [Space Function] was not found in the excel sheet for space: [FrontStorageFlr4]
Zero matches found for [{2=>"Storage area - occsens 1", 1=>"Space Function"}]
space type of [Storage area - occsens 1] and/or building type of [Space Function] was not found in the excel sheet for space: [FrontStorageFlr2]
Zero matches found for [{2=>"Storage area - occsens 8", 1=>"Space Function"}]
space type of [Storage area - occsens 8] and/or building type of [Space Function] was not found in the excel sheet for space: [RearStorageFlr4]
Zero matches found for [{2=>"Storage area - occsens 6", 1=>"Space Function"}]
space type of [Storage area - occsens 6] and/or building type of [Space Function] was not found in the excel sheet for space: [RearStorageFlr2]
Zero matches found for [{2=>"Storage area - occsens 2", 1=>"Space Function"}]
space type of [Storage area - occsens 2] and/or building type of [Space Function] was not found in the excel sheet for space: [FrontStorageFlr3]
Zero matches found for [{2=>"Storage area - occsens 4", 1=>"Space Function"}]
space type of [Storage area - occsens 4] and/or building type of [Space Function] was not found in the excel sheet for space: [LaundryRoomFlr1]
Zero matches found for [{2=>"Storage area - occsens 7", 1=>"Space Function"}]
space type of [Storage area - occsens 7] and/or building type of [Space Function] was not found in the excel sheet for space: [RearStorageFlr3]
Zero matches found for [{2=>"Storage area - occsens 5", 1=>"Space Function"}]
space type of [Storage area - occsens 5] and/or building type of [Space Function] was not found in the excel sheet for space: [RearStorageFlr1]

[padmassun]

template    building_type   space_type  lighting_per_area_w_per_m2  occupancy_per_area_people_per_m2    occupancy_schedule  electric_equipment_per_area_w_per_m2    service_water_heating_peak_flow_per_area_gal_per_h_ft2
NECB 2011   Space Function  Storage area    6.799936823 0.010010441 NECB-E-Occupancy    0.999990712 0.00142675
NECB 2011   Space Function  Storage area - refrigerated 6.799936823 0.010010441 NECB-E-Occupancy    0.999990712 0.00142675

Please change the name of space type to match the ones on the excel sheet as shown above

[jblake59]

I changed the Google sheet a couple of days ago and ran the appropriate "rake data:update:manual" to update the json files. I committed and pushed these changes yesterday. I added the following new space types as part of my solution to issue #164:

Storage area - occsens Storage area - refrigerated - occsens Office - enclosed - occsens

Note that I DID NOT change the lighting_per_area value in the Space Types sheet. Rather, I used a factor in code and also used this factor in the space type test script! I obviously missed another test script!

[phylroy]

is this still an issue? @jblake59 did you also update the modified json files that were created?

[padmassun]

@phylroy I have talked with @jblake59 today regarding the changes to OpenStudio_Standards.xlsx,and I am thinking on creating a script that will update the excel file in the resources folder of BTAPResults, or using the json files (which grabbed the data from OpenStudio_Standards.xlsx) in the BTAPResults measures to run QAQC. I think it would be a good idea to implement the second method, as this would support every template (as long as the data is available in the xlsx file). I am more inclined to use the json files, as it would be more accessible format.

I did take a look at those json files, and the file "manage_OpenStudio_Standards.rb" which creates the json files. If it is possible I would like to implement a modified version of the code present to make the output json file have the data nested by templates (atleast for "Space Types" which is used as part of the qaqc verification). The modified version that I am thinking of would also do unit conversions from imperial to metric only on selected data (lighting_per_area, occupancy_per_area, electric_equipment_per_area,) which is used for qaqc verification.

[phylroy]

Hey Padmassun...There is already a rake method to update the data straight from Google...

Also I'd rather not use the excel file as part of the qaqc...Since this will defeat the purpose of the regression tests.

On Mar 15, 2017 12:41 PM, "Padmassun Rajakareyar" notifications@github.com wrote:

@phylroy https://github.com/phylroy I am thinking of working on creating a script that will update the excel file in the resources folder of BTAPResults. I have also thought about using the json files (which grabbed the data from OpenStudio_Standards.xlsx) in the BTAPResults measures to run QAQC. I think it would be a good idea to implement this method, as this would support every template (as long as the data is available in the xlsx file). I am more inclined to use the json files, as it would be more accessible format.

I did take a look at those json files, and the file "manage_OpenStudio_Standards.rb" which creates the json files. If it is possible I would like to implement a modified version of the code present to make the output json file have the data nested by templates (atleast for "Space Types" which is used as part of the qaqc verification). The modified version that I am thinking of would also do unit conversions from imperial to metric only on selected data (lighting_per_area, occupancy_per_area, electric_equipment_per_area,) which is used for qaqc verification.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NREL/openstudio-standards/issues/193#issuecomment-286802542, or mute the thread https://github.com/notifications/unsubscribe-auth/AE3epi7AmmW_ET-AE9K-nS1s-lTHTM79ks5rmBTCgaJpZM4MZcmD .

[padmassun]

Yes, I am aware of that, and the rake uses the method from "manage_OpenStudio_Standards.rb". I wanted to modify that code a bit to have the information nested by template type (atleast for Space Types)

[padmassun]

Also I'd rather not use the excel file as part of the qaqc...Since this will defeat the purpose of the regression tests.

The excel file in the resource folder of BTAPResults was derived from OpenStudio_Standards.xlsx

[phylroy]

Exactly...Testing data should remain separate from production data. Otherwise you could be in a situation where bad data == bad data is true

On Mar 15, 2017 1:01 PM, "Padmassun Rajakareyar" notifications@github.com wrote:

Also I'd rather not use the excel file as part of the qaqc...Since this will defeat the purpose of the regression tests.

The excel file in the resource folder of BTAPResults was derived from OpenStudio_Standards.xlsx

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NREL/openstudio-standards/issues/193#issuecomment-286809302, or mute the thread https://github.com/notifications/unsubscribe-auth/AE3epvIBTGCbtXbhP5v_YH9QwAUlM5BXks5rmBlYgaJpZM4MZcmD .

[padmassun]

see https://github.com/NREL/OpenStudio-measures/commit/c853421bc8565dce1dffad9c34d8b6a300e520f3