search

NREL / openstudio-standards

Other
83 stars 58 forks source link

QAQC for Lighting power density fails incorrectly for spaces with Reduced Lighting power density #227

Closed padmassun closed 7 years ago

padmassun commented 7 years ago

QAQC's check needs to be modified for Lighting power density for spaces with Occupancy sensors. The QAQC does not apply a factor of 0.9 for 1) space_type of 'Storage area' with floor Area < 100 m2 2) space_type of 'Storage area - refrigerated' with floor Area < 100 m2 3) space_type of 'Office - enclosed' with floor Area < 25 m2 4) space_type of ["Classroom/lecture/training", "Conf./meet./multi-purpose", "Lounge/recreation", "Conf./meet./multi-purpose", "Washroom-sch-A", "Washroom-sch-B", "Washroom-sch-C", "Washroom-sch-D", "Washroom-sch-E", "Washroom-sch-F", "Washroom-sch-G", "Washroom-sch-H", "Washroom-sch-I", "Dress./fitt. - performance arts", "Locker room", "Retail - dressing/fitting"]

jblake59 commented 7 years ago

Yes it does but I'm testing further in light of issue #223. This problem was originally fixed in issue #164. Perhaps we should search closed tickets before posting new ones (and re-open them).

jblake59 commented 7 years ago

@padmassun : Can you provide specific building type failure? I'm testing with outpatient now and seems to be (mostly) working. Still ongoing work.

padmassun commented 7 years ago

UPDATE: @jblake59 I had a discussion with @mlubun and compared your LPD code, and we came across some space types that are missing an LPD factor of 0.9

1) Only "Locker room" was found in your code. There was no "Locker room-sch-A", "Locker room-sch-B" ... "Locker room-sch-I" 2) "Office - open plan" is not included and has to be checked if the area is < 25 m2 3) @mlubun considers "Hospital - medical supply" as a supply space, so it has to be checked if the area is < 100 m2

EDIT: @mlubun confirmed that it is not necessary to include an occupancy sensor for Office - open plan

jblake59 commented 7 years ago

@padmassun : In discussions with @mlubun for original issue #164 decided not to set for "Office - open plan". But no problem changing.

padmassun commented 7 years ago

@jblake59 It is OK to leave "Office - open plan" off the list.

padmassun commented 7 years ago

https://github.com/NREL/openstudio-standards/commit/394798b31ec3f8dfd10b6fa803a81ee1e2936245

jblake59 commented 7 years ago

@phylroy: All fixed. This issue can be closed if Circleci passes.

jblake59 commented 7 years ago

CircleCI passed all tests.