search

NREL / openstudio-standards

Other
83 stars 58 forks source link

model_get_building_climate_zone_and_building_type provides unexpected result #388

Closed DavidGoldwasser closed 1 year ago

DavidGoldwasser commented 6 years ago

https://github.com/NREL/openstudio-standards/blob/5fe0f175d9156c567dfe83a4c4c9948bb65e616c/lib/openstudio-standards/standards/Standards.Model.rb#L3005-L3019

See OpenStudio issue 3148 for more details https://github.com/NREL/OpenStudio/issues/3148

This was one of the issues I hit in testing QAQC measure, work around is pretty ugly. I read the ASHRAE climate zone through OpenStudio API, throw away all climate zones, get new ones, then I can do EUI and other checks in standards that need climate zones.

    # temp code to address climate zone problem mentioned in OpenStudio issue# 3148
    climateZones = @model.getClimateZones
    cz = climateZones.getClimateZones('ASHRAE').first.value
    climateZones.clear
    climateZones.setClimateZone('ASHRAE', cz)

This code would throw away and valid CEC climate zones,

mdahlhausen commented 1 year ago

Assuming this was addressed in OS # 3871