NREL / pCrunch

Apache License 2.0
8 stars 11 forks source link

error in Jupyter notebook example reading OpenFAST ascii outputs #24

Open rclarke17 opened 8 months ago

rclarke17 commented 8 months ago

When I try running the jupyter notebook example I get an error in the section "Interacting with output files" when it tries reading my OpenFAST ASCII output files.
The error originates in line 460 of openfast.py. I believe I was able to fix it by specifying 'latin-1' within the decode method. But am unsure how robust that fix is.

gbarter commented 8 months ago

Can you include a screenshot or copy-paste the error info? I just tried the example.ipynb notebook and it works fine. Just to be sure, I am also adding it into the regular CI tests. I also labelled the other notebook (on batch_processing) as deprecated because that uses very old syntax.

rclarke17 commented 8 months ago

image

This error goes away once I specify 'latin-1' in the .decode on line 460 of openfast.py

gbarter commented 8 months ago

Hmm, a little surprised by that. Do you know how to submit a PR back to the code with your changes?

rclarke17 commented 8 months ago

Yeah, I can do that if you'd like

gbarter commented 8 months ago

Thank you!