search

NREL / pCrunch

Apache License 2.0
8 stars 11 forks source link

WEIS Refactor #7

Closed JakeNunemaker closed 3 years ago

JakeNunemaker commented 3 years ago

TODO:

nikhar-abbas commented 3 years ago

TODO:

  • [x] Revise setup.py
  • [x] Revise README
  • [x] Add .github actions for tests and automatic deployment
  • [x] @nikhar-abbas Can you add me to the PyPi project so I can finish setting up the GitHub action for auto deployment?
  • [x] Add versioneer
  • [x] Add PyPi API Token to secrets
  • [ ] What to do with old scripts that haven't been updated?

On the last bullet here, I think you can delete them unless they are providing something particularly useful.

JakeNunemaker commented 3 years ago

Ok this is pretty much ready to go with the exception of figuring out if we want to keep the last few post processing scripts and update them or build them back up as they are needed next.

I've done some revisions to the setup script, versioning and added some GitHub actions for automatic testing (there could be more added here in the future) and deployment. I also slimmed down the README a bit since a lot of it wasn't relevant anymore.

JakeNunemaker commented 3 years ago

That's a good point - I didn't think about submitting it against dev. Does that make more sense @nikhar-abbas @ptrbortolotti ?

ptrbortolotti commented 3 years ago

yeah maybe develop is a safer choice so that we can test it out in the next weeks

JakeNunemaker commented 3 years ago

Sounds good - I'll close this one and submit a new one to develop