search

NREL / rdtools

PV Analysis Tools in Python
https://rdtools.readthedocs.io/
MIT License
158 stars 67 forks source link

remove warnings from logic clip filter #366

Closed cdeline closed 1 year ago

cdeline commented 1 year ago

Code changes are covered by tests Code changes have been evaluated for compatibility/integration with TrendAnalysis New functions added to __init__.py API.rst is up to date, along with other sphinx docs pages Example notebooks are rerun and differences in results scrutinized

Fixes #365. Logic clipping filter is published and validated, not likely to change in the future. for the 3.0 release (and 3.0.0a1 runs) it would be nice to get rid of the logfile clutter. We can still decide on whether to make it the default method or not, but the method itself is stable, or at least will be by the time of any 3.0.0 public release..

mdeceglie commented 1 year ago

I'm OK with this change. I think we can ignore all the failing tests at this stage. Some will be fixed by #362 , others have been introduced in the aggregated_filters_for_trials branch and we will clean them up when we figure out what 3.0 will really look like. Do you agree @cdeline ?