NREL / rdtools

PV Analysis Tools in Python
https://rdtools.readthedocs.io/
MIT License
146 stars 61 forks source link

Update ReadTheDocs configuration #395

Closed kandersolar closed 8 months ago

kandersolar commented 9 months ago

ReadTheDocs is requiring a change in the configuration file (see this failed build):

Your builds will stop working soon! "build.image" config key is deprecated and it will be removed soon. Read our blog post to know how to migrate to new key "build.os" and ensure your project continues building successfully.

This PR makes the necessary configuration updates.

mdeceglie commented 8 months ago

I was able to resolve one of the bugs with our test suite and pandas 2.1. The other seems to be a pandas issue https://github.com/pandas-dev/pandas/issues/55794

mdeceglie commented 8 months ago

Shall we push this through and confine the requirements to pandas<2.1 while we await a fix on the pandas side?

kandersolar commented 8 months ago

Makes sense to me to go ahead with merging this and track the pandas issue separately!

mdeceglie commented 8 months ago

@cdeline @martin-springer I agree with @kandersolar that we should push this through for now. Would one of you be able to review this?

mdeceglie commented 8 months ago

The failing notebook checks are related to a Datahub error affecting our example data. I'm confident the ntoebooks haven't changed with this one, so pushing it through.