NREL / rdtools

PV Analysis Tools in Python
https://rdtools.readthedocs.io/
MIT License
146 stars 61 forks source link

Add missing tests #413

Closed martin-springer closed 2 weeks ago

martin-springer commented 2 months ago

This is a draft. Mainly to get Codecov updated.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.25%. Comparing base (1f25b2f) to head (f2c48cd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## aggregated_filters_for_trials #413 +/- ## ================================================================= + Coverage 71.70% 75.25% +3.55% ================================================================= Files 13 13 Lines 2820 2825 +5 ================================================================= + Hits 2022 2126 +104 + Misses 798 699 -99 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mdeceglie commented 2 weeks ago

@martin-springer is it possible to re-trigger the codecov report?

martin-springer commented 2 weeks ago

@martin-springer is it possible to re-trigger the codecov report?

@mdeceglie I do believe so, but haven't done that much myself yet. Looking through the quick start guide (https://docs.codecov.com/docs/quick-start), you can execute the upload of coverage reports from the command line. This page outlines the process (https://docs.codecov.com/docs/codecov-uploader).

We might want to tweak the github action, to not only run when a new PR is created but also when commits are made to a PR. This should then take care of it. I can take a look at how we would need to change the config for that.