Advance pvlib upper bound from 0.11 to 0.12

NREL / rdtools

PV Analysis Tools in Python

https://rdtools.readthedocs.io/

MIT License

146 stars 61 forks source link

Advance pvlib upper bound from 0.11 to 0.12 #423

Closed kandersolar closed 1 week ago

kandersolar commented 2 weeks ago

[ ] Code changes are covered by tests
[ ] Code changes have been evaluated for compatibility/integration with TrendAnalysis
[ ] New functions added to __init__.py
[ ] API.rst is up to date, along with other sphinx docs pages
[ ] Example notebooks are rerun and differences in results scrutinized
[ ] Updated changelog

RdTools currently requires pvlib<0.11.0. With pvlib now in the 0.11.x series, I don't think there turned out to be any relevant breaking changes (see what's new), so we can increase that upper limit to allow 0.11.*.

mdeceglie commented 1 week ago

Thanks for the PR @kandersolar! For ease of managing the flow here, I'm going to sweep this into our changes for 3.0 expected this summer.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.10%. Comparing base (ab8bdc8) to head (449cca9).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## aggregated_filters_for_trials #423 +/- ## ============================================================== Coverage 96.10% 96.10% ============================================================== Files 11 11 Lines 2206 2206 ============================================================== Hits 2120 2120 Misses 86 86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mdeceglie commented 1 week ago

It's not immediately clear which of the breaking changes listed in the pvlib docs are causing the tests to fail. any thoughts @kandersolar?

kandersolar commented 1 week ago

@mdeceglie it looks to be fixed now!