NREL / rdtools

PV Analysis Tools in Python
https://rdtools.readthedocs.io/
MIT License
158 stars 67 forks source link

update examples and docs for RdTools 3 #429

Closed mdeceglie closed 1 month ago

mdeceglie commented 2 months ago
mdeceglie commented 2 months ago

To do: Get the example file on the DuraMAT datahub updated to include the NSRDB data

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.10%. Comparing base (a46b348) to head (e916cd3).

Files with missing lines Patch % Lines
rdtools/soiling.py 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## aggregated_filters_for_trials #429 +/- ## ============================================================== Coverage 96.10% 96.10% ============================================================== Files 11 11 Lines 2208 2209 +1 ============================================================== + Hits 2122 2123 +1 Misses 86 86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mdeceglie commented 2 months ago

@martin-springer @kandersolar Any ideas on how I managed to break the nbval tests here?

martin-springer commented 2 months ago

@martin-springer @kandersolar Any ideas on how I managed to break the nbval tests here?

@mdeceglie - A missing comma in the workflow file and upload-artifact had to be updated to v4.

There's an issue tough with the newer version of nbval ignoring the semicolon: https://github.com/computationalmodelling/nbval/issues/194

Unfortunately, that bug hasn't been fixed in 0.11 either. We need to decide on how we want to address that.

mdeceglie commented 1 month ago

@kandersolar Is it time to remove the experimental warning from the availability module? Seems pretty locked in, we've used it in a number of different applications successfully, and I'm not aware of plans to modify it.

kandersolar commented 1 month ago

I have no plans to change the method either. No objection from me on removing the warning.