search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Offshore Supply Curve Point Region Assignment #279

Closed alopez04 closed 3 years ago

alopez04 commented 3 years ago

Bug Description For reV offshore, it looks like the supply curve points are assigned to a region based on the offshore cable landfall/interconnection. This creates differences in state capacity totals depending on the land-based siting regime - even though offshore capacity/exclusions remain constant. A more consistent approach would be to assign the region based on the supply curve point location using offshore region boundaries.

Charge code WEPG.10348.08.01.03

MRossol commented 3 years ago

@grantbuster, will this be fixed with the NRWAL integration? I think the actual issue was that offshore SC points were pre-defined by ORCA.

grantbuster commented 3 years ago

I'm not sure what the proposed solution is. The offshore supply curve points derived from NRWAL outputs will have the meta data attributes from the WTK. In anthony's comment: "assign the region based on the supply curve point location using offshore region boundaries", what offshore region boundaries are those? You can always create exclusion grids with meta data and have aggregation summarize that meta data for the offshore sc points.

MRossol commented 3 years ago

Again my understanding of the "bug" is that the ORCA points are pre-defined and thus don't get any data during aggregation. @alopez04, now that offshore points are aggregated like onshore points and we can apply layers to them can we call this "fixed".

grantbuster commented 3 years ago

Gotcha, yes we can apply aggregation "data layers" to the offshore supply curve points now (reeds regions or whatever else you cook up). However i should note that the WTK doesnt have country/state/county values for the offshore meta data so the offshore supply curve points will not automatically have meta data for these fields.

MRossol commented 3 years ago

Very good point, couldn't we add that in through NRWAL. It would be a bit hacky but we could add region data columns to the inputs and then pass them through

grantbuster commented 3 years ago

Yes I think youre right