reV outputs handler doesnt have correct Resource attributes

NREL / reV

Renewable Energy Potential (reV) Model

https://nrel.github.io/reV/

BSD 3-Clause "New" or "Revised" License

107 stars 24 forks source link

reV outputs handler doesnt have correct Resource attributes #300

Closed grantbuster closed 3 years ago

grantbuster commented 3 years ago

Bug Description The reV outputs handler never calls resource init() and so doesnt get a lot of the correct attributes initialized. Can we call super().init()?

Here are some of the things we need, for example to run the Outputs.dtypes property: https://github.com/NREL/rex/blob/291689263ac0d99e4779d5e3f7c84b8e7736cdec/rex/resource.py#L729-L739

MRossol commented 3 years ago

Implemented a new BaseResource class: https://github.com/NREL/reV/issues/300 We can now super().init() from BaseResource https://github.com/NREL/reV/blob/494ef2486cbc42c68796a16bd2773a4bcea35b91/reV/handlers/outputs.py#L22 https://github.com/NREL/reV/blob/494ef2486cbc42c68796a16bd2773a4bcea35b91/reV/handlers/outputs.py#L155-L161