search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

New gid_map argument break Generation CLI #304

Closed WilliamsTravis closed 3 years ago

WilliamsTravis commented 3 years ago

Bug Description reV generation module fails using cli with most recent update. Related to this commit.

Full Traceback

 File "/home/ngrue/.conda-envs/rev/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/reV/generation/cli_gen.py", line 766, in <module>
    main(obj={})
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/core.py", line 1256, in invoke
    Command.invoke(self, ctx)
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/ngrue/.conda-envs/rev/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
TypeError: direct() got an unexpected keyword argument 'gid_map'

System (please complete the following information):

MRossol commented 3 years ago

This is Grue's fault for wanting a new release...

WilliamsTravis commented 3 years ago

Yeah, Grue's fault...

grantbuster commented 3 years ago

Hot fix on main (https://github.com/NREL/reV/commit/46c21eb5dc4d25a89b7ab8e658bb2e20331902a4) @WilliamsTravis can you try running from a dev env before we do another release that doesnt actually work?

WilliamsTravis commented 3 years ago

Just successfully ran a test with the fix.

MRossol commented 3 years ago

Good news v0.5.3 released, BUT github actions seem to be down so not published to pypi or conda yet. Will keep checking