Sc update

[MRossol]

Was actually pretty straightforward. Only had to make two changes: 1) If trans_cap_cost in trans_table don't compute costs 2) Recursion magic to merge sc_points and trans_tables by capacity!

Also some general clean-up.

Still need to test/write tests, waiting on data from @mikebannis

[MRossol]

closes #311

[codecov-commenter]

Codecov Report

Merging #314 (1510361) into main (ec96286) will increase coverage by 0.04%. The diff coverage is 99.09%.

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   76.24%   76.28%   +0.04%     
==========================================
  Files         117      117              
  Lines       14667    14711      +44     
==========================================
+ Hits        11183    11223      +40     
- Misses       3484     3488       +4     

Flag	Coverage Δ
unittests	76.28% <99.09%> (+0.04%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup.py	0.00% <ø> (ø)
reV/supply_curve/supply_curve.py	89.97% <98.43%> (-1.52%)	:arrow_down:
reV/handlers/transmission.py	81.81% <100.00%> (+1.98%)	:arrow_up:
reV/supply_curve/cli_supply_curve.py	29.79% <100.00%> (ø)
reV/supply_curve/points.py	83.30% <100.00%> (ø)
reV/version.py	100.00% <100.00%> (ø)
tests/test_supply_curve_compute.py	96.63% <100.00%> (+1.03%)	:arrow_up:
tests/test_supply_curve_exclusions.py	96.99% <0.00%> (-0.76%)	:arrow_down:
tests/test_gen_pv.py	93.21% <0.00%> (-0.46%)	:arrow_down:
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec96286...1510361. Read the comment docs.

[MRossol]

@grantbuster I think this should be ready for Travis. I added tests to check against a baseline and to check to make sure that the final sc table is connecting sc_points to features in the correct capacity bins.

One NOTE for Travis, I updated the trans_cap_cost column to be trans_cap_cost_mw. This is to help distinguish the costs coming in from Mike and the costs computed in reV based off of the sc_gid capacity.

[grantbuster]

Okay, looks like tests are still failing so lets let travis run off of a dev branch.

is trans_cap_cost_mw a dollars per MW unit? I would suggest including the per_mw, as a numerator/denominator confusion could be disastrous.

[MRossol]

I'll fix the tests now, but good call. I'll change it to _per_mw

[MRossol]

One the baseline tests? I'm 99% sure the difference was in the file ordering when multiple tables are loaded. I noticed that there are a few transmission features with identical cost and the new tests were connecting to a different feature. Seems like it was a strange sort change.