search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

update trans feature to sc point capacity mapping #325

Closed MRossol closed 3 years ago

MRossol commented 3 years ago

Fix bug that would drop sc_gids with capacity > max_cap in trans tables

MRossol commented 3 years ago

@grantbuster, do you want to review this?

grantbuster commented 3 years ago

No thats okay, i dont really understand what the issue is. Why are the reVX tests failing?

MRossol commented 3 years ago

no idea, there are no logs but it also says it passed, I'm guessing a github actions hiccup.

Do you mind putting quick eyes on the change. I want to make sure I didn't mess up the logic. The issues was that with the new transmission tables we need to map the SC points to the proper transmission table based on capacity as follows:

sc_point['capacity'] <= trans_table['max_cap']

The issue with this that Travis found was that there are some sc_points with capacity > 1500MW which is the capacity of the largest tie-lines. So these features were connected to garbage.

The fix I've hopefully implemented is to take all of the sc_points that exceed the max_cap in the tranmission tables and for each transmission feature that they map to, connect to the feature with the largest max_cap.