NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Incorporate non-90m Land Use Grids into Minimum Area Filter #384

Closed WilliamsTravis closed 2 years ago

WilliamsTravis commented 2 years ago

Why this feature is necessary: The minimum area filter does not appear to work properly for land use grids that have a resolution other than 90m.

A possible solution is: When the _area_filter is method is called in exclusions.py here, pass the area in sq km of a single land use cell as an argument ("excl_area"), which is set as a default of .0081 (assuming a 90m grid) in the same script here.

I have considered the following alternatives: I can just apply the minimum area filter to the supply curves in a post-processing step, but I will be missing the "contiguous" part of this function.

Additional context We've been running reV for much smaller study areas lately in which a finer resolution is more computationally feasibly, so we're attempting to improve our capacity estimates by using 10m grids.

Charge code Depending on how much time this will take I may have to confer with the team.

Urgency / Timeframe Not urgent, I can filter these points out manually for a rough estimate.

grantbuster commented 2 years ago

10m??? who are we trying to impress??

Can you try this dev branch out and see if that works: https://github.com/NREL/reV/tree/gb/min_area_pixel_area

It will just take the area from the exclusion file attributes.

If this works, do you need a version release?

WilliamsTravis commented 2 years ago

Puerto Rico!

Okay sure, will do soon. Don't need version release.

grantbuster commented 2 years ago

385

grantbuster commented 2 years ago

closed in #385