NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Bespoke bug fixes #391

Closed ppinchuk closed 1 year ago

ppinchuk commented 1 year ago

Fix for several bugs:

All logic changes include tests.

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.52% // Head: 80.65% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (15e0c5d) compared to base (12c17e1). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #391 +/- ## ========================================== + Coverage 80.52% 80.65% +0.12% ========================================== Files 143 143 Lines 19866 19911 +45 ========================================== + Hits 15998 16059 +61 + Misses 3868 3852 -16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `80.65% <100.00%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL/reV/pull/391?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/bespoke/bespoke.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2Jlc3Bva2UvYmVzcG9rZS5weQ==) | `89.39% <100.00%> (+0.47%)` | :arrow_up: | | [reV/supply\_curve/exclusions.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9leGNsdXNpb25zLnB5) | `83.66% <100.00%> (+0.04%)` | :arrow_up: | | [reV/supply\_curve/points.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9wb2ludHMucHk=) | `89.00% <100.00%> (+0.33%)` | :arrow_up: | | [reV/supply\_curve/sc\_aggregation.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3N1cHBseV9jdXJ2ZS9zY19hZ2dyZWdhdGlvbi5weQ==) | `78.80% <100.00%> (-0.38%)` | :arrow_down: | | [tests/test\_bespoke.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9iZXNwb2tlLnB5) | `92.84% <100.00%> (+0.33%)` | :arrow_up: | | [tests/test\_qa\_qc\_summary.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9xYV9xY19zdW1tYXJ5LnB5) | `89.47% <100.00%> (ø)` | | | [tests/test\_supply\_curve\_exclusions.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9zdXBwbHlfY3VydmVfZXhjbHVzaW9ucy5weQ==) | `98.40% <100.00%> (+0.72%)` | :arrow_up: | | [reV/losses/scheduled.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2xvc3Nlcy9zY2hlZHVsZWQucHk=) | `100.00% <0.00%> (ø)` | | | [reV/losses/power\_curve.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2xvc3Nlcy9wb3dlcl9jdXJ2ZS5weQ==) | `98.86% <0.00%> (+<0.01%)` | :arrow_up: | | [reV/config/project\_points.py](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9wcm9qZWN0X3BvaW50cy5weQ==) | `85.41% <0.00%> (+0.04%)` | :arrow_up: | | ... and [12 more](https://codecov.io/gh/NREL/reV/pull/391/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.