search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

reV Geothermal Module V1 #399

Closed ppinchuk closed 1 year ago

ppinchuk commented 1 year ago

First version of reV Geothermal Module.

This update allows reV to run the SAM-GETEM module in the same fashion as wind/solar. Only generation is impacted - reV functions just like the other technologies for the aggregation and supply curve modules. Representative profiles may need to be adjusted to support the geothermal module in the future.

Other tweaks may come in a future patch if the results indicate the need.

This update also includes an upgrade to PySAM 4.

ppinchuk commented 1 year ago

Will convert from draft to actual PR after #398 is merged (don't want to conflict with versioning)

codecov-commenter commented 1 year ago

Codecov Report

Base: 81.02% // Head: 81.18% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (de44051) compared to base (30ecad3). Patch coverage: 90.65% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #399 +/- ## ========================================== + Coverage 81.02% 81.18% +0.15% ========================================== Files 143 144 +1 Lines 20147 20380 +233 ========================================== + Hits 16325 16546 +221 - Misses 3822 3834 +12 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.18% <90.65%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/SAM/defaults.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9kZWZhdWx0cy5weQ==) | `75.00% <78.78%> (-0.21%)` | :arrow_down: | | [reV/SAM/generation.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9nZW5lcmF0aW9uLnB5) | `91.59% <88.66%> (-1.93%)` | :arrow_down: | | [tests/test\_gen\_geothermal.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9nZW5fZ2VvdGhlcm1hbC5weQ==) | `95.77% <95.77%> (ø)` | | | [reV/SAM/SAM.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL1NBTS9TQU0ucHk=) | `84.27% <100.00%> (+2.31%)` | :arrow_up: | | [reV/config/project\_points.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9wcm9qZWN0X3BvaW50cy5weQ==) | `85.79% <100.00%> (+0.42%)` | :arrow_up: | | [reV/generation/generation.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2dlbmVyYXRpb24vZ2VuZXJhdGlvbi5weQ==) | `87.19% <100.00%> (ø)` | | | [reV/version.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [tests/test\_config.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9jb25maWcucHk=) | `98.00% <100.00%> (+0.18%)` | :arrow_up: | | [tests/test\_sam.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9zYW0ucHk=) | `97.43% <100.00%> (+0.85%)` | :arrow_up: | | [reV/losses/scheduled.py](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2xvc3Nlcy9zY2hlZHVsZWQucHk=) | `100.00% <0.00%> (ø)` | | | ... and [12 more](https://codecov.io/gh/NREL/reV/pull/399?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.