search

NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Gb/rep res gids #404

Closed grantbuster closed 1 year ago

grantbuster commented 1 year ago

@WilliamsTravis , wondering if you've ever had problems with this. I was surprised that you couldnt run rep-profiles from a base supply curve table with new generation data that was run with a different set of project points. This should fix that.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@46e72ca). Click here to learn what that means. Patch coverage: 98.27% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #404 +/- ## ======================================= Coverage ? 81.27% ======================================= Files ? 144 Lines ? 20568 Branches ? 0 ======================================= Hits ? 16717 Misses ? 3851 Partials ? 0 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.27% <98.27%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/NREL/reV/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/config/rep\_profiles\_config.py](https://codecov.io/gh/NREL/reV/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL2NvbmZpZy9yZXBfcHJvZmlsZXNfY29uZmlnLnB5) | `39.47% <ø> (ø)` | | | [reV/rep\_profiles/cli\_rep\_profiles.py](https://codecov.io/gh/NREL/reV/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3JlcF9wcm9maWxlcy9jbGlfcmVwX3Byb2ZpbGVzLnB5) | `32.40% <ø> (ø)` | | | [reV/rep\_profiles/rep\_profiles.py](https://codecov.io/gh/NREL/reV/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL3JlcF9wcm9maWxlcy9yZXBfcHJvZmlsZXMucHk=) | `91.14% <97.56%> (ø)` | | | [tests/test\_rep\_profiles.py](https://codecov.io/gh/NREL/reV/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9yZXBfcHJvZmlsZXMucHk=) | `98.18% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

WilliamsTravis commented 1 year ago

I have not had problems with this, never considered doing it, but this is potentially very useful and I'm all about it!