ppinchuk
commented
1 year ago Ok @grantbuster, take a peek at the new Gen class. In particular, note that reV_run is now an instance method instead of a class method. This allows the docstring for the parameters to be broken up between the instance method and the class init. All parameters only have to be documented in the one place where they are pulled into the object. Note the new way of using the Gen class
gen = Gen(tech, points, sam_configs, res_file, lr_res_file=None,
output_request=('cf_mean',), site_data=None, curtailment=None,
gid_map=None, sites_per_worker=None,
mem_util_lim=0.4, scale_outputs=True, write_mapped_gids=False,
bias_correct=None)
gen.reV_run(max_workers=1, pool_size=(os.cpu_count() * 2), timeout=1800)does resemble the old class method implantation:
gen = Gen.reV_run(tech, points, sam_configs, res_file, lr_res_file=None,
output_request=('cf_mean',), site_data=None, curtailment=None,
gid_map=None, max_workers=1, sites_per_worker=None,
pool_size=(os.cpu_count() * 2), timeout=1800,
points_range=None, out_fpath=None, mem_util_lim=0.4,
scale_outputs=True, write_mapped_gids=False,
bias_correct=None)No docstrings have actually been updated yet, I have focused purely on the code logic for now.
Let me know if you see any major red flags or funky things you'd like me to address.
codecov-commenter
grantbuster
This update contains quite a few changes, mostly to the reV CLI. Primarily, all CLI functionality has been moved to GAPs. This means a lot of the reV code having to do with the CLI has been deprecated.
Most importantly, a big documentation overhaul has been included.
This update also includes fixes for a few outstanding issues.
Since GAPs is not available on the platform,
condasupport is dropped with this update.reVXtests will fail due to breaking API changes. Will update reVX code to confirm to new changes once this PR is merged.