NREL / reV

Renewable Energy Potential (reV) Model
https://nrel.github.io/reV/
BSD 3-Clause "New" or "Revised" License
107 stars 24 forks source link

Add support for NRWAL CSV output #422

Closed ppinchuk closed 1 year ago

ppinchuk commented 1 year ago

I added a version of this code back in Feb 2022 when we were doing hydrogen runs but never merged it because it made the CLI somewhat messy. This PR finally merges a version of that code. This option is mainly intended to support huge (50k-100k) batched parametric NRWAL runs. Travis indicated the need for this kind of feature in some of the upcoming green steel work, for example.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% :tada:

Comparison is base (497bb7d) 86.87% compared to head (1bf0424) 87.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #422 +/- ## ========================================== + Coverage 86.87% 87.00% +0.13% ========================================== Files 122 122 Lines 16810 16916 +106 ========================================== + Hits 14603 14718 +115 + Misses 2207 2198 -9 ``` | [Flag](https://app.codecov.io/gh/NREL/reV/pull/422/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/NREL/reV/pull/422/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | `87.00% <100.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/NREL/reV/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL) | Coverage Δ | | |---|---|---| | [reV/nrwal/nrwal.py](https://app.codecov.io/gh/NREL/reV/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-cmVWL25yd2FsL25yd2FsLnB5) | `86.48% <100.00%> (+2.17%)` | :arrow_up: | | [tests/test\_nrwal.py](https://app.codecov.io/gh/NREL/reV/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL#diff-dGVzdHMvdGVzdF9ucndhbC5weQ==) | `98.84% <100.00%> (+0.40%)` | :arrow_up: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/NREL/reV/pull/422/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=NREL)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.